[codex] docs: rename callback example getter#3541
Open
abhijeetnardele24-hash wants to merge 1 commit intomicrosoft:v2from
Open
[codex] docs: rename callback example getter#3541abhijeetnardele24-hash wants to merge 1 commit intomicrosoft:v2from
abhijeetnardele24-hash wants to merge 1 commit intomicrosoft:v2from
Conversation
Signed-off-by: abhijeet nardele <234410808+abhijeetnardele24-hash@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the “Optional Parameters in Callbacks” examples in the Declaration Files Do’s and Don’ts docs to avoid implying that a getter-like method should return void, while keeping the guidance about callback parameter optionality the same.
Changes:
- Renames the example
Fetchermethod fromgetObjecttofetchObjectin both the WRONG and OK snippets. - Keeps the callback signature guidance unchanged, but makes the example read more like async “fetch” work.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetcherexample method fromgetObjecttofetchObjectvoidCloses #3501.
Validation